-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nylas credentials API #290
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 13:07 — with
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 13:17 — with
GitHub Actions
Failure
mrashed-dev
suggested changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR @kraju3! I left some comments, let me know if you disagree
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 14:22 — with
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 14:22 — with
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 14:23 — with
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 14:24 — with
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 14:28 — with
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 14:33 — with
GitHub Actions
Failure
Co-authored-by: Mostafa Rashed <[email protected]> Update nylas/models/credentials.py Changing typedDic to Protocol for AdminConsentSettings Co-authored-by: Mostafa Rashed <[email protected]> Reformating The credential resource Co-authored-by: Mostafa Rashed <[email protected]> Moving credentials to auth resource Removed credential Request Revert "Removed credential Request" This reverts commit 519250ccde80632f3d6e69a9280517726e185c1b. Removed base request Resolved comments
kraju3
force-pushed
the
v6.0.0-beta-kiran
branch
from
October 17, 2023 14:39
7be713f
to
bf54c06
Compare
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 14:39 — with
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
October 17, 2023 16:07 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the model and resource for credentials API.
JIRA Ticket
https://nylas.atlassian.net/browse/TW-2407