Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nylas credentials API #290

Closed
wants to merge 4 commits into from
Closed

Conversation

kraju3
Copy link
Contributor

@kraju3 kraju3 commented Oct 17, 2023

Description

This PR contains the model and resource for credentials API.

JIRA Ticket

https://nylas.atlassian.net/browse/TW-2407

Copy link
Contributor

@mrashed-dev mrashed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @kraju3! I left some comments, let me know if you disagree

nylas/client.py Outdated Show resolved Hide resolved
nylas/models/credentials.py Outdated Show resolved Hide resolved
nylas/models/credentials.py Outdated Show resolved Hide resolved
nylas/resources/credentials.py Outdated Show resolved Hide resolved
Co-authored-by: Mostafa Rashed <[email protected]>

Update nylas/models/credentials.py

Changing typedDic to Protocol for AdminConsentSettings

Co-authored-by: Mostafa Rashed <[email protected]>

Reformating The credential resource

Co-authored-by: Mostafa Rashed <[email protected]>

Moving credentials to auth resource

Removed credential Request

Revert "Removed credential Request"

This reverts commit 519250ccde80632f3d6e69a9280517726e185c1b.

Removed base request

Resolved comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants